Apache Tomcat Maven Plugin :: Tomcat 7.x

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
21	7	16	59

Files

Files	I	W	E
org/apache/tomcat/maven/plugin/tomcat7/AbstractCatalinaMojo.java	0	1	0
org/apache/tomcat/maven/plugin/tomcat7/AbstractTomcat7Mojo.java	1	1	1
org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java	2	1	40
org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java	1	8	5
org/apache/tomcat/maven/plugin/tomcat7/run/ExecWarMojo.java	0	0	2
org/apache/tomcat/maven/plugin/tomcat7/run/ExecWarOnlyMojo.java	0	0	1
org/apache/tomcat/maven/plugin/tomcat7/run/ExtendedTomcat.java	0	2	1
org/apache/tomcat/maven/plugin/tomcat7/run/ExtraDependency.java	0	0	1
org/apache/tomcat/maven/plugin/tomcat7/run/ExtraResource.java	0	0	1
org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java	0	0	1
org/apache/tomcat/maven/plugin/tomcat7/run/RunWarOnlyMojo.java	0	0	1
org/apache/tomcat/maven/plugin/tomcat7/run/ShutdownMojo.java	0	0	1
org/apache/tomcat/maven/plugin/tomcat7/run/WarRunDependency.java	3	1	4
org/apache/tomcat/maven/plugin/tomcat7/run/Webapp.java	0	2	0

Rules

Rules	Violations	Severity
FileLength	0	Error
RegexpHeader headerFile: `"target/checkstyle-header.txt"`	11	Error
FileTabCharacter eachLine: `"true"`	0	Error
LeftCurly option: `"nl"`	0	Error
RightCurly option: `"alone"`	0	Error
LineLength max: `"120"` ignorePattern: `"@version\|@see\|@todo\|TODO"`	4	Error
MemberName	0	Error
JavadocMethod scope: `"protected"`	13	Warning
JavadocType allowUnknownTags: `"true"` scope: `"protected"`	0	Error
JavadocVariable scope: `"protected"`	7	Info
ConstantName	0	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	0	Error
MethodLength	2	Error
ParameterNumber	0	Error
EmptyForIteratorPad option: `"space"`	0	Error
OperatorWrap	0	Error
ParenPad option: `"space"`	36	Error
WhitespaceAfter	0	Error
WhitespaceAround	0	Error
ModifierOrder	0	Error
RedundantModifier	0	Error
AvoidNestedBlocks	0	Error
EmptyBlock option: `"text"`	0	Error
NeedBraces	0	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
HiddenField ignoreConstructorParameter: `"true"` ignoreSetter: `"true"`	3	Warning
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MagicNumber ignoreNumbers: `"-4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 32, 64, 100, 128, 256, 512, 1000, 1024"`	0	Error
MissingSwitchDefault	0	Error
RedundantThrows	3	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
InterfaceIsType	0	Error
VisibilityModifier packageAllowed: `"true"` protectedAllowed: `"true"`	3	Error
UpperEll	0	Error

Details

org/apache/tomcat/maven/plugin/tomcat7/AbstractCatalinaMojo.java

Violation	Message	Line
	'password' hides a field.	176

org/apache/tomcat/maven/plugin/tomcat7/AbstractTomcat7Mojo.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	48

org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2
	'(' is not followed by whitespace.	72
	')' is not preceded with whitespace.	72
	'(' is not followed by whitespace.	78
	')' is not preceded with whitespace.	78
	'(' is not followed by whitespace.	81
	')' is not preceded with whitespace.	81
	'(' is not followed by whitespace.	84
	')' is not preceded with whitespace.	84
	'(' is not followed by whitespace.	90
	')' is not preceded with whitespace.	90
	'(' is not followed by whitespace.	93
	')' is not preceded with whitespace.	93
	'(' is not followed by whitespace.	96
	')' is not preceded with whitespace.	96
	'(' is not followed by whitespace.	102
	')' is not preceded with whitespace.	103
	'(' is not followed by whitespace.	110
	')' is not preceded with whitespace.	110
	Missing a Javadoc comment.	113
	Missing a Javadoc comment.	116
	'(' is not followed by whitespace.	128
	')' is not preceded with whitespace.	128
	'(' is not followed by whitespace.	134
	')' is not preceded with whitespace.	134
	'(' is not followed by whitespace.	143
	')' is not preceded with whitespace.	143
	'(' is not followed by whitespace.	150
	')' is not preceded with whitespace.	151
	'(' is not followed by whitespace.	158
	')' is not preceded with whitespace.	158
	'(' is not followed by whitespace.	164
	')' is not preceded with whitespace.	164
	'(' is not followed by whitespace.	170
	')' is not preceded with whitespace.	171
	'(' is not followed by whitespace.	190
	')' is not preceded with whitespace.	191
	'(' is not followed by whitespace.	197
	')' is not preceded with whitespace.	197
	Method length is 268 lines (max allowed is 150).	200
	Missing a Javadoc comment.	200
	Line is longer than 120 characters.	347
	Redundant throws: 'FileNotFoundException' is subclass of 'IOException'.	473

org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2
	Line is longer than 120 characters.	304
	Missing a Javadoc comment.	411
	Expected @throws tag for 'ServletException'.	529
	Missing a Javadoc comment.	583
	Expected @throws tag for 'MojoExecutionException'.	687
	Expected @throws tag for 'MojoExecutionException'.	742
	Method length is 197 lines (max allowed is 150).	876
	Missing a Javadoc comment.	1085
	Missing a Javadoc comment.	1120
	Redundant throws: 'MalformedURLException' is subclass of 'IOException'.	1182
	Redundant throws: 'MalformedURLException' is subclass of 'IOException'.	1217
	'webapps' hides a field.	1220
	'contextFile' hides a field.	1260

org/apache/tomcat/maven/plugin/tomcat7/run/ExecWarMojo.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2
	Line is longer than 120 characters.	29

org/apache/tomcat/maven/plugin/tomcat7/run/ExecWarOnlyMojo.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2

org/apache/tomcat/maven/plugin/tomcat7/run/ExtendedTomcat.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	45

org/apache/tomcat/maven/plugin/tomcat7/run/ExtraDependency.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2

org/apache/tomcat/maven/plugin/tomcat7/run/ExtraResource.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2

org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2

org/apache/tomcat/maven/plugin/tomcat7/run/RunWarOnlyMojo.java

Violation	Message	Line
	Line is longer than 120 characters.	27

org/apache/tomcat/maven/plugin/tomcat7/run/ShutdownMojo.java

Violation	Message	Line
	Line does not match expected header line of '^ \* Licensed to the Apache Software Foundation $ASF$ under one\s*$'.	4

org/apache/tomcat/maven/plugin/tomcat7/run/WarRunDependency.java

Violation	Message	Line
	Line does not match expected header line of '^\s*$'.	2
	Missing a Javadoc comment.	32
	Variable 'dependency' must be private and have accessor methods.	32
	Missing a Javadoc comment.	34
	Variable 'contextPath' must be private and have accessor methods.	34
	Missing a Javadoc comment.	36
	Variable 'contextXml' must be private and have accessor methods.	36
	Missing a Javadoc comment.	38

org/apache/tomcat/maven/plugin/tomcat7/run/Webapp.java

Violation	Message	Line
	Missing a Javadoc comment.	35
	Missing a Javadoc comment.	40